Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 21 Feb 2018 17:28:17 -0800
From: Kees Cook <>
To: Christopher Lameter <>
Cc: Matthew Wilcox <>, Andrew Morton <>, 
	Matthew Wilcox <>, Linux-MM <>, 
	LKML <>, 
	Kernel Hardening <>
Subject: Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct

On Thu, Feb 15, 2018 at 9:06 AM, Christopher Lameter <> wrote:
> On Thu, 15 Feb 2018, Matthew Wilcox wrote:
>> I dunno.  Yes, there's macro trickery going on here, but it certainly
>> resembles a function.  It doesn't fail any of the rules laid out in that
>> chapter of coding-style about unacceptable uses of macros.
> It sure looks like a function but does magic things with the struct
> parameter. So its not working like a function and the capitalization makes
> one aware of that.

I think readability trumps that -- nearly everything else in the
kernel that hides these kinds of details is lower case.


Kees Cook
Pixel Security

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.