Date: Wed, 21 Feb 2018 16:23:26 -0800 From: Kees Cook <keescook@...omium.org> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>, Patrick McLean <chutzpah@...too.org>, Emese Revfy <re.emese@...il.com>, Al Viro <viro@...iv.linux.org.uk>, Bruce Fields <bfields@...hat.com>, "Darrick J. Wong" <darrick.wong@...cle.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux NFS Mailing List <linux-nfs@...r.kernel.org>, Thorsten Leemhuis <regressions@...mhuis.info>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com> Subject: Re: RANDSTRUCT structs need linux/compiler_types.h (Was: [nfsd4] potentially hardware breaking regression in 4.14-rc and 4.13.11) On Wed, Feb 21, 2018 at 4:22 PM, Linus Torvalds <torvalds@...ux-foundation.org> wrote: > On Wed, Feb 21, 2018 at 4:12 PM, Kees Cook <keescook@...omium.org> wrote: >> >> Do you want me to send the patch for this, or do you already have it >> prepared? > > I'd rather get something explicitly tested. I tried my earlier patch > with "make allmodconfig" (and a fix to nfsd to make it compile), but > now I'm back to testing hjl's gas updates so it would be better to get > a tested commit with a good commit message. > >> The body-fields I had prepared for the nfs were: >> >> Reported-by: Patrick McLean <chutzpah@...too.org> >> Reported-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name> > > Oh, I think Maciej needs to get more than a "Reported-by:". This was a > really subtle thing that we didn't figure out in the original thread, > so give him a gold star in the form of "Root-caused-by:" or something. Oops, I just sent this out. I will adjust a re-send. I couldn't find a documented field name for this... > *Fixing* this ends up being a one-liner or so. Finding the cause was > the painful part. Yes indeed! -Kees -- Kees Cook Pixel Security
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.