Date: Thu, 15 Feb 2018 09:55:11 -0600 (CST) From: Christopher Lameter <cl@...ux.com> To: Matthew Wilcox <willy@...radead.org> cc: Andrew Morton <akpm@...ux-foundation.org>, Matthew Wilcox <mawilcox@...rosoft.com>, linux-mm@...ck.org, Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com Subject: Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct On Wed, 14 Feb 2018, Matthew Wilcox wrote: > > Uppercase like the similar KMEM_CACHE related macros in > > include/linux/slab.h?> > > Do you think that would look better in the users? Compare: Does looking matter? I thought we had the convention that macros are uppercase. There are some tricks going on with the struct. Uppercase shows that something special is going on. > Making it look like a function is more pleasing to my eye, but I'll > change it if that's the only thing keeping it from being merged. This should be consistent throughout the source.
Powered by blists - more mailing lists