Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 11 Feb 2018 13:01:57 -0800
From: Matthew Wilcox <>
To: Randy Dunlap <>
Cc: Philippe Ombredanne <>,
	Igor Stoppa <>,
	Jonathan Corbet <>, Kees Cook <>,,,,
	Christoph Hellwig <>,,,,
	LKML <>,
Subject: Re: [PATCH 2/6] genalloc: selftest

On Sun, Feb 11, 2018 at 12:27:14PM -0800, Randy Dunlap wrote:
> On 02/11/18 12:22, Philippe Ombredanne wrote:
> > nit... For a comment in .h this line should be instead its own comment
> > as the first line:
> >> +/* SPDX-License-Identifier: GPL-2.0 */
> Why are we treating header files (.h) differently than .c files?
> Either one can use the C++ "//" comment syntax.

This is now documented!


   If a specific tool cannot handle the standard comment style, then the
   appropriate comment mechanism which the tool accepts shall be used. This
   is the reason for having the "/\* \*/" style comment in C header
   files. There was build breakage observed with generated .lds files where
   'ld' failed to parse the C++ comment. This has been fixed by now, but
   there are still older assembler tools which cannot handle C++ style

Personally, I find this disappointing.  I find this:

// SPDX-License-Identifier: GPL-2.0+
 * XArray implementation
 * Copyright (c) 2017 Microsoft Corporation
 * Author: Matthew Wilcox <>

much less visually appealling than

 * XArray implementation
 * Copyright (c) 2017 Microsoft Corporation
 * Author: Matthew Wilcox <>
 * SPDX-License-Identifier: GPL-2.0+

I can't see this variation making a tag extraction tool harder to write.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.