Date: Sun, 11 Feb 2018 03:04:57 +0200 From: Igor Stoppa <igor.stoppa@...wei.com> To: Randy Dunlap <rdunlap@...radead.org>, <jglisse@...hat.com>, <keescook@...omium.org>, <mhocko@...nel.org>, <labbott@...hat.com>, <hch@...radead.org>, <willy@...radead.org> CC: <cl@...ux.com>, <linux-security-module@...r.kernel.org>, <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>, <kernel-hardening@...ts.openwall.com> Subject: Re: [PATCH 4/6] Protectable Memory On 05/02/18 00:06, Randy Dunlap wrote: > On 02/04/2018 08:47 AM, Igor Stoppa wrote: [...] >> + * pmalloc_create_pool - create a new protectable memory pool - > > Drop trailing " -". yes >> + * @name: the name of the pool, must be unique > > Is that enforced? Will return NULL if @name is duplicated? ok, I'll state it more clearly that it's enforced [...] >> + * @pool: handler to the pool to be used for memory allocation > > handle (I think) yes, also for all the other ones [...] >> + * avoid sleping during allocation. > > sleeping yes [...] >> + * opposite to what is allocated on-demand when pmalloc runs out of free > > opposed to yes >> + * space already existing in the pool and has to invoke vmalloc. >> + * >> + * Returns true if the vmalloc call was successful, false otherwise. > > Where is the allocated memory (pointer)? I.e., how does the caller know > where that memory is? > Oh, that memory isn't yet available to the caller until it calls pmalloc(), right? yes, it's a way to: - preemptively beef up the pool, before entering atomic context (unlikely that it will be needed, but possible), so that there is no need to allocate extra pages (assuming one can estimate the max memory that will be requested) - avoid fragmentation caused by allocating smaller groups of pages I'll add explanation for this. [...] >> + * @size: amount of memory (in bytes) requested >> + * @gfp: flags for page allocation >> + * >> + * Allocates memory from an unprotected pool. If the pool doesn't have >> + * enough memory, and the request did not include GFP_ATOMIC, an attempt >> + * is made to add a new chunk of memory to the pool >> + * (a multiple of PAGE_SIZE), in order to fit the new request. > > fill > What if @size is > PAGE_SIZE? Nothing special, it gets rounded up to the nearest multiple of PAGE_SIZE. vmalloc doesn't have only drawbacks ;-) [...] >> + * Returns the pointer to the memory requested upon success, >> + * NULL otherwise (either no memory available or pool already read-only). > > It would be good to use the > * Return: > kernel-doc notation for return values. yes, good point, I'm fixing it everywhere in the patchset [...] >> + * will be availabel for further allocations. > > available yes [...] >> +/** > > /** means that the following comments are kernel-doc notation, but these > comments are not, so just use /* there, please. yes, also to the others [...] >> + /* is_pmalloc_object gets called pretty late, so chances are high >> + * that the object is indeed of vmalloc type >> + */ > > Multi-line comment style is > /* > * comment1 > * comment..N > */ yes, also to the others -- igor
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.