Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 25 Jan 2018 13:08:38 -0800
From: Andy Lutomirski <>
To: Linus Torvalds <>
Cc: Andy Lutomirski <>, "the arch/x86 maintainers" <>, LKML <>, 
	Greg Kroah-Hartman <>, Alan Cox <>, 
	Jann Horn <>, Samuel Neves <>, 
	Dan Williams <>, 
	Kernel Hardening <>, Borislav Petkov <>
Subject: Re: [PATCH] x86/retpoline/entry: Disable the entire SYSCALL64 fast
 path with retpolines on

On Thu, Jan 25, 2018 at 1:06 PM, Linus Torvalds
<> wrote:
> On Thu, Jan 25, 2018 at 1:02 PM, Andy Lutomirski <> wrote:
>> Feel free to Acked-by: Andy Lutomirski <> that patch.
>> Or I can grab it and send it to -tip.
> I'm not going to apply it for 4.15, I just wanted to see how it
> looked, and do some minimal profiling.
> From the profiles, as mentioned, moving 'status' from thread_struct to
> thread_info is probably worth doing. But I didn't look at the impact
> of that at all.
> So it should go through all the normal channels in -tip for 4.16.
> I'll happily sign off on the patch, but it was really pretty mindless,
> so I'm not sure I need the authorship either.
>> Re: the trampoline not showing up: if I find some time, I'll try to
>> wire it up correctly in kallsyms.
> That would be lovely. Right now the system call exit shows up pretty
> clearly in profiles, and most of it is (obviously) the cr3 write. So
> the missing entry trampoline is not insignificant.

With retpoline, the retpoline in the trampoline sucks.  I don't need
perf for that -- I've benchmarked it both ways.  It sucks.  I'll fix
it, but it'll be kind of complicated.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.