Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 18 Jan 2018 08:29:57 -0800
From: Christoph Hellwig <>
To: Al Viro <>
Cc: Linus Torvalds <>,
	Network Development <>,
	Dan Williams <>,
	Linux Kernel Mailing List <>,, Andi Kleen <>,
	Kees Cook <>,,
	Greg Kroah-Hartman <>,
	the arch/x86 maintainers <>,
	Ingo Molnar <>, "H. Peter Anvin" <>,
	Thomas Gleixner <>,
	Andrew Morton <>,
	Alan Cox <>, David Miller <>
Subject: Re: [RFC][PATCH] get rid of the use of set_fs() (by way of
 kernel_recvmsg()) in sunrpc

> 	We could turn ->msg_control/->msg_controllen into another
> iov_iter, but seeing that we never do scatter-gather for those
> IMO that would be a massive overkill.  A flag controlling whether
> ->msg_control is kernel or userland pointer would do, especially
> since we already have a flag for "do we want a native or compat
> layout for cmsg" in there.

While your current hack seems like a nice short term improvement
I think we need an iov_iter or iov_iter-light there in the long run.
Same for ioctl so that we can pass properly typed kernel or user
buffers through without all these set_fs hacks.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.