Date: Sat, 30 Dec 2017 21:30:55 +1100 From: "Tobin C. Harding" <me@...in.cc> To: Kaiwan N Billimoria <kaiwan.billimoria@...il.com> Cc: linux-kernel@...r.kernel.org, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com> Subject: Re: [PATCH] leaking_addresses: add generic 32-bit support On Tue, Dec 26, 2017 at 07:48:55AM +0530, Kaiwan N Billimoria wrote: > The script attempts to detect the architecture it's running upon; as of now, > we explicitly support x86_64, PPC64 and x86_32. > If it's one of them, we proceed "normally". If we fail to detect the arch, > we fallback to 64-bit scanning, unless the user has passed either of these > option switches: "--opt-32bit" and/or "--page-offset-32bit=<val>". > > If so, we switch to scanning for leaked addresses based on the value of > PAGE_OFFSET (via an auto-detected or fallback mechanism). > > As of now, we have code (or "rules") to detect special cases for x86_64 and PPC64 > (in the get_address_re sub). Also, we now have also builtin "stubs", for lack of a better term, where additional rules for other 64-bit arch's can be plugged into the code, > in future, as applicable. > > Signed-off-by: Kaiwan N Billimoria <kaiwan.billimoria@...il.com> > > --- > scripts/leaking_addresses.pl | 190 +++++++++++++++++++++++++++++++++++-------- > 1 file changed, 156 insertions(+), 34 deletions(-) > > This patch is based on Tobin's suggestions and my replies to them (see prev email in this thread). Hi, Can you resend this with a version number please. Also can you include what testing you have done please. I'm away on Christmas holidays at the moment but I'll review soon as I'm back. Thanks, Tobin.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.