Date: Mon, 18 Dec 2017 22:37:38 -0500 From: Steven Rostedt <rostedt@...dmis.org> To: "Tobin C. Harding" <me@...in.cc> Cc: kernel-hardening@...ts.openwall.com, Tycho Andersen <tycho@...ho.ws>, Linus Torvalds <torvalds@...ux-foundation.org>, Kees Cook <keescook@...omium.org>, Andrew Morton <akpm@...ux-foundation.org>, Daniel Borkmann <daniel@...earbox.net>, Masahiro Yamada <yamada.masahiro@...ionext.com>, Alexei Starovoitov <ast@...nel.org>, linux-kernel@...r.kernel.org, Network Development <netdev@...r.kernel.org> Subject: Re: [PATCH 3/3] trace: print address if symbol not found On Tue, 19 Dec 2017 14:00:11 +1100 "Tobin C. Harding" <me@...in.cc> wrote: > I ran through these as outlined here for the new version (v4). This hits > the modified code but doesn't test symbol look up failure. stacktrace shouldn't post non kernel values, unless there's a frame pointer that isn't handled by kallsyms. As for the other two, we could probably force a failure, like: # echo 'hist:keys=hrtimer.sym' > \ events/timer/hrtimer_start/trigger # cat events/timer/hrtimer_start/hist And then just add sym-offset too. > > I also configured kernel with 'Perform a startup test on ftrace' for > good luck. > > Are you happy with this level of testing? Can you try the above. -- Steve
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.