[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b693b0d5-ff37-f8df-444d-db389566a75b@linux.com>
Date: Fri, 8 Dec 2017 02:05:20 +0300
From: Alexander Popov <alex.popov@...ux.com>
To: Laura Abbott <labbott@...hat.com>, kernel-hardening@...ts.openwall.com,
Kees Cook <keescook@...omium.org>, PaX Team <pageexec@...email.hu>,
Brad Spengler <spender@...ecurity.net>, Ingo Molnar <mingo@...nel.org>,
Andy Lutomirski <luto@...nel.org>, Tycho Andersen <tycho@...ho.ws>,
Mark Rutland <mark.rutland@....com>,
Ard Biesheuvel <ard.biesheuvel@...aro.org>, Borislav Petkov <bp@...en8.de>,
Thomas Gleixner <tglx@...utronix.de>, "H . Peter Anvin" <hpa@...or.com>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>, x86@...nel.org
Subject: Re: [PATCH RFC v6 2/6] gcc-plugins: Add STACKLEAK plugin for tracking
the kernel stack
On 06.12.2017 21:57, Laura Abbott wrote:
> On 12/05/2017 03:33 PM, Alexander Popov wrote:
>> + /* Parse the plugin arguments */
>> + if (argc != 1) {
>> + error(G_("bad number of the plugin arguments: %d"), argc);
>> + return 1;
>> + }
>> +
>> + if (strcmp(argv[i].key, "track-min-size")) {
>> + error(G_("unknown option '-fplugin-arg-%s-%s'"),
>> + plugin_name, argv[i].key);
>> + return 1;
>> + }
>> +
>> + if (!argv[i].value) {
>> + error(G_("no value supplied for option '-fplugin-arg-%s-%s'"),
>> + plugin_name, argv[i].key);
>> + return 1;
>> + }
>> +
>> + track_frame_size = atoi(argv[i].value);
>> + if (track_frame_size < 0) {
>> + error(G_("invalid option argument '-fplugin-arg-%s-%s=%s'"),
>> + plugin_name, argv[i].key, argv[i].value);
>> + return 1;
>> + }
>
> I don't see i getting updated anywhere, which seems to be an artifact of
> removing the for loop. I'd prefer if you just kept the loop since the
> arm64 version requires a --disable option like structleak.
Ok, no problem, I'll return the loop and add --disable option in v7.
Best regards,
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
