Date: Mon, 25 Sep 2017 18:38:13 +0200 From: "Jason A. Donenfeld" <Jason@...c4.com> To: David Howells <dhowells@...hat.com> Cc: linux-security-module@...r.kernel.org, keyrings@...r.kernel.org, kernel-hardening@...ts.openwall.com, LKML <linux-kernel@...r.kernel.org>, Eric Biggers <ebiggers3@...il.com>, Herbert Xu <herbert@...dor.apana.org.au>, Kirill Marinushkin <k.marinushkin@...il.com>, security@...nel.org, stable@...r.kernel.org Subject: Re: [PATCH v7 2/2] security/keys: rewrite all of big_key crypto On Mon, Sep 25, 2017 at 4:43 PM, David Howells <dhowells@...hat.com> wrote: > Jason A. Donenfeld <Jason@...c4.com> wrote: > >> + /* no ->update(); don't add it without changing big_key_crypt() nonce */ > > Should update be a problem. It's should be a complete payload replacement - > kind of like unlink and add, but keeping the same key ID and description. Not sure I parsed your message correctly, but that comment there was a suggestion from Eric several months ago when I first posted it. The idea is that the key shouldn't be reused with the same nonce, so in case somebody ambitious comes along and tries to add an .update function, they'll be reminded to take this into account. Alternatively they might choose to just generate a new key, which is fine too. Either way, it's a useful warning to have in place.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.