Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 7 Sep 2017 12:44:14 -0600
From: Tycho Andersen <>
To: Christoph Hellwig <>
	Marco Benatto <>,
	Juerg Haefliger <>,
	Konrad Rzeszutek Wilk <>
Subject: Re: [PATCH v6 04/11] swiotlb: Map the buffer if it was unmapped by

On Thu, Sep 07, 2017 at 11:10:15AM -0700, Christoph Hellwig wrote:
> > -	if (PageHighMem(pfn_to_page(pfn))) {
> > +	if (PageHighMem(page) || xpfo_page_is_unmapped(page)) {
> Please don't sprinkle xpfo details over various bits of code.
> Just add a helper with a descriptive name, e.g.
> page_is_unmapped()
> that also includes the highmem case, as that will easily document
> what this check is doing.

Will do, thanks.

Patch 7 has a similar feel to this one, I can add a wrapper around
__clean_dcache_area_pou() if that makes sense?


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.