Date: Mon, 14 Aug 2017 12:18:59 -0400 (EDT) From: Nicolas Pitre <nicolas.pitre@...aro.org> To: Dave Martin <Dave.Martin@....com> cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>, Mark Rutland <mark.rutland@....com>, Kees Cook <keescook@...omium.org>, Arnd Bergmann <arnd@...db.de>, Marc Zyngier <marc.zyngier@....com>, Kernel Hardening <kernel-hardening@...ts.openwall.com>, Russell King <linux@...linux.org.uk>, Tony Lindgren <tony@...mide.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Thomas Garnier <thgarnie@...gle.com>, Matt Fleming <matt@...eblueprint.co.uk> Subject: Re: [PATCH 02/30] ARM: assembler: introduce adr_l, ldr_l and str_l macros On Mon, 14 Aug 2017, Dave Martin wrote: > On Mon, Aug 14, 2017 at 04:38:02PM +0100, Ard Biesheuvel wrote: > > That's a trick, actually, which I failed to add a comment for. Shame shame shame ! > > We use .arm sections in the thumb2 kernel, and using these macros > > there would result in the wrong offset to be used. Adding the .w > > suffix forces an error in the assembler which even results in a fairly > > meaningful error message complaining about using .w in ARM code. > > Ewww... I think it'd be best to add a comment explaining that. Absolutely! Nicolas
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.