Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 14 Aug 2017 12:18:59 -0400 (EDT)
From: Nicolas Pitre <>
To: Dave Martin <>
cc: Ard Biesheuvel <>, 
    Mark Rutland <>, Kees Cook <>, 
    Arnd Bergmann <>, Marc Zyngier <>, 
    Kernel Hardening <>, 
    Russell King <>, Tony Lindgren <>, 
    "" <>, 
    Thomas Garnier <>, 
    Matt Fleming <>
Subject: Re: [PATCH 02/30] ARM: assembler: introduce adr_l, ldr_l and str_l

On Mon, 14 Aug 2017, Dave Martin wrote:

> On Mon, Aug 14, 2017 at 04:38:02PM +0100, Ard Biesheuvel wrote:
> > That's a trick, actually, which I failed to add a comment for.

Shame shame shame !

> > We use .arm sections in the thumb2 kernel, and using these macros
> > there would result in the wrong offset to be used. Adding the .w
> > suffix forces an error in the assembler which even results in a fairly
> > meaningful error message complaining about using .w in ARM code.
> Ewww... I think it'd be best to add a comment explaining that.



Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.