Date: Mon, 24 Jul 2017 09:32:58 -0700 From: Thomas Garnier <thgarnie@...gle.com> To: Brian Gerst <brgerst@...il.com> Cc: "H. Peter Anvin" <hpa@...or.com>, Herbert Xu <herbert@...dor.apana.org.au>, "David S . Miller" <davem@...emloft.net>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Josh Poimboeuf <jpoimboe@...hat.com>, Arnd Bergmann <arnd@...db.de>, Matthias Kaehlcke <mka@...omium.org>, Boris Ostrovsky <boris.ostrovsky@...cle.com>, Juergen Gross <jgross@...e.com>, Paolo Bonzini <pbonzini@...hat.com>, Radim Krčmář <rkrcmar@...hat.com>, Joerg Roedel <joro@...tes.org>, Andy Lutomirski <luto@...nel.org>, Borislav Petkov <bp@...en8.de>, "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>, Borislav Petkov <bp@...e.de>, Christian Borntraeger <borntraeger@...ibm.com>, "Rafael J . Wysocki" <rjw@...ysocki.net>, Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>, Tejun Heo <tj@...nel.org>, Christoph Lameter <cl@...ux.com>, Kees Cook <keescook@...omium.org>, Paul Gortmaker <paul.gortmaker@...driver.com>, Chris Metcalf <cmetcalf@...lanox.com>, "Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>, Andrew Morton <akpm@...ux-foundation.org>, Christopher Li <sparse@...isli.org>, Dou Liyang <douly.fnst@...fujitsu.com>, Masahiro Yamada <yamada.masahiro@...ionext.com>, Daniel Borkmann <daniel@...earbox.net>, Markus Trippelsdorf <markus@...ppelsdorf.de>, Peter Foley <pefoley2@...oley.com>, Steven Rostedt <rostedt@...dmis.org>, Tim Chen <tim.c.chen@...ux.intel.com>, Ard Biesheuvel <ard.biesheuvel@...aro.org>, Catalin Marinas <catalin.marinas@....com>, Matthew Wilcox <mawilcox@...rosoft.com>, Michal Hocko <mhocko@...e.com>, Rob Landley <rob@...dley.net>, Jiri Kosina <jkosina@...e.cz>, "H . J . Lu" <hjl.tools@...il.com>, Paul Bolle <pebolle@...cali.nl>, Baoquan He <bhe@...hat.com>, Daniel Micay <danielmicay@...il.com>, "the arch/x86 maintainers" <x86@...nel.org>, "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, xen-devel@...ts.xenproject.org, kvm list <kvm@...r.kernel.org>, linux-pm <linux-pm@...r.kernel.org>, linux-arch <linux-arch@...r.kernel.org>, linux-sparse@...r.kernel.org, Kernel Hardening <kernel-hardening@...ts.openwall.com> Subject: Re: [RFC 21/22] x86/module: Add support for mcmodel large and PLTs On Wed, Jul 19, 2017 at 10:34 AM, Brian Gerst <brgerst@...il.com> wrote: > On Wed, Jul 19, 2017 at 11:58 AM, Thomas Garnier <thgarnie@...gle.com> wrote: >> On Tue, Jul 18, 2017 at 8:59 PM, Brian Gerst <brgerst@...il.com> wrote: >>> On Tue, Jul 18, 2017 at 9:35 PM, H. Peter Anvin <hpa@...or.com> wrote: >>>> On 07/18/17 15:33, Thomas Garnier wrote: >>>>> With PIE support and KASLR extended range, the modules may be further >>>>> away from the kernel than before breaking mcmodel=kernel expectations. >>>>> >>>>> Add an option to build modules with mcmodel=large. The modules generated >>>>> code will make no assumptions on placement in memory. >>>>> >>>>> Despite this option, modules still expect kernel functions to be within >>>>> 2G and generate relative calls. To solve this issue, the PLT arm64 code >>>>> was adapted for x86_64. When a relative relocation go outside its range, >>>>> a dynamic PLT entry is used to correctly jump to the destination. >>>> >>>> Why large as opposed to medium or medium-PIC? >>> >>> Or for that matter, why not small-PIC? We aren't changing the size of >>> the kernel to be larger than 2G text or data. Small-PIC would still >>> allow it to be placed anywhere in the address space, and would >>> generate far better code. >> >> My understanding was that small=PIC and medium=PIC assume that the >> module code is in the lower 2G of memory. I will do additional testing >> on the modules to confirm that. > > That is only for small/medium absolute (non-PIC) code. Think about > userspace shared libraries. They are not limited to being mapped in > the lower 2G of the address space. I built lkdtm with mcmodel=(kernel, small, medium & large). Comparing the same instruction and its relocation in lkdtm (lkdtm_register_cpoint). On mcmodel=kernel: 1b8: 48 c7 c7 00 00 00 00 mov $0x0,%rdi 1bb: R_X86_64_32S .rodata.str1.8+0x50 On mcmodel=small and mcmodel=medium: 1b8: bf 00 00 00 00 mov $0x0,%edi 1b9: R_X86_64_32 .rodata.str1.8+0x50 On mcmodel=large: 235: 48 bf 00 00 00 00 00 movabs $0x0,%rdi 23c: 00 00 00 237: R_X86_64_64 .rodata.str1.8+0x50 The kernel mcmodel extends the sign of the address. It assumes you are in the top 2G of the address space. So the relocated pointer 0x8XXXXXXX becomes 0xFFFFFFFF8XXXXXXX. The small and medium mcmodels assume the pointer is within the lower part of the address space. The generate pointer has the 32-bit high part to zero. You can only map the module between 0 and 0xFFFFFFFF. The large mcmodel can handle a full 64-bit pointer. That's why I use the large mcmodel on modules. I cannot use PIE due to how the modules are linked. > > -- > Brian Gerst -- Thomas
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.