Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 15 May 2017 14:12:48 +0100
From: David Howells <dhowells@...hat.com>
To: "Jason A. Donenfeld" <Jason@...c4.com>
Cc: dhowells@...hat.com, netdev@...r.kernel.org,
    linux-kernel@...r.kernel.org, davem@...emloft.net,
    kernel-hardening@...ts.openwall.com,
    Steffen Klassert <steffen.klassert@...unet.com>,
    Herbert Xu <herbert@...dor.apana.org.au>,
    Sabrina Dubroca <sd@...asysnail.net>,
    "Michael S. Tsirkin" <mst@...hat.com>,
    Jason Wang <jasowang@...hat.com>
Subject: Re: [PATCH v8 1/5] skbuff: return -EMSGSIZE in skb_to_sgvec to prevent overflow

Jason A. Donenfeld <Jason@...c4.com> wrote:

> +int skb_to_sgvec(struct sk_buff *skb, struct scatterlist *sg, int offset, int len)
> ...
> -int skb_to_sgvec(struct sk_buff *skb, struct scatterlist *sg, int offset, int len)

Is there a reason you moved skb_to_sgvec() in the file rather than just moving
the comment to it (since you moved the comment anyway)?

David

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.