Date: Tue, 09 May 2017 16:03:20 +0200 From: Johannes Berg <johannes@...solutions.net> To: "Jason A. Donenfeld" <Jason@...c4.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, davem@...emloft.net, kernel-hardening@...ts.openwall.com Subject: Re: [PATCH v7 0/5] skb_to_sgvec hardening On Tue, 2017-05-09 at 15:50 +0200, Jason A. Donenfeld wrote: > The recent bug with macsec and historical one with virtio have > indicated that letting skb_to_sgvec trounce all over an sglist > without checking the length is probably a bad idea. And it's not > necessary either: an sglist already explicitly marks its last > item, and the initialization functions are diligent in doing so. > Thus there's a clear way of avoiding future overflows. > > So, this patchset, from a high level, makes skb_to_sgvec return > a potential error code, and then adjusts all callers to check > for the error code. Perhaps you should add __must_check annotation to the function prototype(s)? johannes
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.