Date: Thu, 27 Apr 2017 13:34:21 +0100 From: One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk> To: Matt Brown <matt@...tt.com> Cc: Jann Horn <jannh@...gle.com>, serge@...lyn.com, jmorris@...ei.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, jslaby@...e.com, Jonathan Corbet <corbet@....net>, Kees Cook <keescook@...omium.org>, Andrew Morton <akpm@...ux-foundation.org>, kernel-hardening@...ts.openwall.com, linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org Subject: Re: [PATCH v5 0/2] security: tty: make TIOCSTI ioctl require CAP_SYS_ADMIN > > Which is the sudo case and why sudo uses a separate pty/tty pair as it's > > not just TIOCSTI that's an issue but there are a load of ioctls that do > > things like cause signals to the process or are just annoying - > > vhangup(), changing the speed etc > > > > (And for console changing the keymap - which is a nasty one) > > > > Are any of these annoyances potential security issues? I would be happy > to add patches or modify this one to include extra hardening measures. Or you could just use pty/tty pairs properly the way sudo and other applications do perfectly well. Lots of them are potential security issues - if I sent your console to 1x1 char, change the font and keymap you'd proably be peeved 8-) It's not about hardening against all these (which would break lots of legitimate use cases), it's about having the affected applications do the right thing. It makes sense that TIOCSTI honours namespaces. However it and everything else are correctly handled by creating the lower security level process with its own pty/tty pair. Alan
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.