Date: Tue, 14 Feb 2017 16:34:06 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: Kees Cook <keescook@...omium.org> Cc: Djalal Harouni <tixxdz@...il.com>, LKML <linux-kernel@...r.kernel.org>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, Lafcadio Wluiki <wluikil@...il.com> Subject: Re: [PATCH v4 1/2] procfs: use an enum for possible hidepid values On Mon, 13 Feb 2017 14:16:30 -0800 Kees Cook <keescook@...omium.org> wrote: > On Mon, Jan 16, 2017 at 5:23 AM, Djalal Harouni <tixxdz@...il.com> wrote: > > From: Lafcadio Wluiki <wluikil@...il.com> > > > > Previously, the hidepid parameter was checked by comparing literal > > integers 0, 1, 2. Let's add a proper enum for this, to make the checking > > more expressive: > > > > 0 ___ HIDEPID_OFF > > 1 ___ HIDEPID_NO_ACCESS > > 2 ___ HIDEPID_INVISIBLE > > > > This changes the internal labelling only, the userspace-facing interface > > remains unmodified, and still works with literal integers 0, 1, 2. > > > > No functional changes. > > > > Acked-by: Kees Cook <keescook@...omium.org> > > Acked-by: Djalal Harouni <tixxdz@...il.com> > > Signed-off-by: Lafcadio Wluiki <wluikil@...il.com> > > Andrew, can you take this? It's a sensible cleanup to drop literals in > favor of defines. Sure. Djalal, I converted your acked-by into a signed-off-by, as described in Documentation/SubmittingPatches (soon to become Documentation/process/submitting-patches.rst).
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.