Date: Fri, 27 Jan 2017 19:37:47 +0100 From: Simon Horman <horms@...ge.net.au> To: Pablo Neira Ayuso <pablo@...filter.org> Cc: Julian Anastasov <ja@....bg>, David Windsor <dwindsor@...il.com>, netdev@...r.kernel.org, kernel-hardening@...ts.openwall.com, netfilter-devel@...r.kernel.org, lvs-devel@...r.kernel.org, wensong@...ux-vs.org, keescook@...omium.org, elena.reshetova@...el.com, ishkamiel@...il.com Subject: Re: [PATCH v2 net] net: free ip_vs_dest structs when refcnt=0 On Fri, Jan 27, 2017 at 01:21:11PM +0100, Pablo Neira Ayuso wrote: > On Fri, Jan 27, 2017 at 09:07:38AM +0100, Simon Horman wrote: > > On Thu, Jan 26, 2017 at 10:49:10PM +0200, Julian Anastasov wrote: > > > > > > Hello, > > > > > > On Mon, 23 Jan 2017, David Windsor wrote: > > > > > > > Currently, the ip_vs_dest cache frees ip_vs_dest objects when their > > > > reference count becomes < 0. Aside from not being semantically sound, > > > > this is problematic for the new type refcount_t, which will be introduced > > > > shortly in a separate patch. refcount_t is the new kernel type for > > > > holding reference counts, and provides overflow protection and a > > > > constrained interface relative to atomic_t (the type currently being > > > > used for kernel reference counts). > > > > > > > > Per Julian Anastasov: "The problem is that dest_trash currently holds > > > > deleted dests (unlinked from RCU lists) with refcnt=0." Changing > > > > dest_trash to hold dest with refcnt=1 will allow us to free ip_vs_dest > > > > structs when their refcnt=0, in ip_vs_dest_put_and_free(). > > > > > > > > Signed-off-by: David Windsor <dwindsor@...il.com> > > > > > > Thanks! I tested the first version and this one > > > just adds the needed changes in comments, so > > > > > > Signed-off-by: Julian Anastasov <ja@....bg> > > > > > > Simon and Pablo, this is more appropriate for > > > ipvs-next/nf-next. Please apply! > > > > Pablo, would you mind taking this one directly into nf-next? > > > > Signed-off-by: Simon Horman <horms@...ge.net.au> > > Sure, no problem. I'll take it. Thanks! Thanks!
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.