Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 23 Jan 2017 07:52:17 +0000
From: "Reshetova, Elena" <elena.reshetova@...el.com>
To: Greg KH <gregkh@...uxfoundation.org>, "keescook@...omium.org"
	<keescook@...omium.org>
CC: "kernel-hardening@...ts.openwall.com"
	<kernel-hardening@...ts.openwall.com>, "arnd@...db.de" <arnd@...db.de>,
	"tglx@...utronix.de" <tglx@...utronix.de>, "mingo@...hat.com"
	<mingo@...hat.com>, "Anvin, H Peter" <h.peter.anvin@...el.com>,
	"peterz@...radead.org" <peterz@...radead.org>, "will.deacon@....com"
	<will.deacon@....com>, "dwindsor@...il.com" <dwindsor@...il.com>
Subject: RE: [RFCv2 PATCH 00/18] refcount_t API + usage

> -----Original Message-----
> From: Greg KH [mailto:gregkh@...uxfoundation.org]
> Sent: Wednesday, January 18, 2017 12:31 PM
> To: Reshetova, Elena <elena.reshetova@...el.com>
> Cc: kernel-hardening@...ts.openwall.com; keescook@...omium.org;
> arnd@...db.de; tglx@...utronix.de; mingo@...hat.com; Anvin, H Peter
> <h.peter.anvin@...el.com>; peterz@...radead.org; will.deacon@....com;
> dwindsor@...il.com
> Subject: Re: [RFCv2 PATCH 00/18] refcount_t API + usage
> 
> On Wed, Jan 18, 2017 at 11:11:29AM +0200, Elena Reshetova wrote:
> > Changes since v1:
> >  - kref INIT fixes are moved to a proper separate commit
> >  - Peter's commits are now properly integrated into series
> >  - various small fixes are incorporated based on testing
> >    results and feedback
> >
> > This patch series is build on top of Peter's Zijlstra patches
> > that provide refcount_t type and API definition.
> > The rest of patches convert various places of kernel subsystems
> > where atomic_t was used for reference counting to new refcount_t type and
> API.
> > By doing this, we make sure that underflows and overflows
> > cannot occur in these places and therefore no use-after-free situation
> > can be created and misused by an attacker.
> 
> Your first 7 patches are fine, and most of them are already in the tip
> tree and getting use in linux-next now.  I'd recommend submitting the
> remaining one(s?) that are not there yet to be included, that will get
> refcount_t into 4.11-rc1.

Ok, so then I assume that I don't have to worry about the first 7 patches and
I just wait for them to show up. 

> 
> Then comes the real work :)
> 
> You will need to break up the remaining patches into "one-per-type" and
> start submitting them to the various submaintainers for inclusion.  

Could you please elaborate more on "one-per-type"? Sorry if the question is
too basic, but I could not find any proper explanations anywhere now. 
If I run get_maintainer.pl, it sometimes produces rather big list (like it was the
case with atomic changes for example) and for a big patch like for example networking
it might not be straightforward to determine how to break it up properly. 

If there any BKMs or generic heuristics that people use in this case? 
Does it help to send it to a general subsystem maintainer and mailing list first
for a look and ask how they prefer it to be broken up?


>You
> can do that once 4.11-rc1 is out.  That's going to be a lot of different
> patches, and your patch-maintaince skills are going to be tested here...
> 
> With those submissions, lots of them will start to trickly into
> linux-next and start to show up in 4.12-rc1.  You'll then need to
> refresh your patchset, drop the ones that were accepted, and do it all
> over again.  If some maintainers are just ignoring you, you'll have to
> go through some other tree for them (I can take the driver ones through
> my driver tree.)
> 
> It's going to be work, but is totally doable.  I recommend setting up a
> separate git or quilt tree that can get included into linux-next and
> kbuild for testing and refreshing as the patches start to flow upstream.

Kees do you have preference on how to do this? Can we setup a builder on our
github tree or is it better to do on your kernel.org tree? If latter, then I guess 
we would need to have rights to manage it all the time.

I would prefer git-managed tree since I feel more familiar with git than quilt.  

> 
> Kernel development isn't always a lot of coding, it's primarily dealing
> with stuff like this, welcome to the club :)

Thanks :)


Best Regards,
Elena.

> 
> hope this helps,
> 
> greg k-h

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.