Date: Thu, 29 Dec 2016 17:41:09 +0100 From: Greg KH <gregkh@...uxfoundation.org> To: Elena Reshetova <elena.reshetova@...el.com> Cc: kernel-hardening@...ts.openwall.com, keescook@...omium.org, arnd@...db.de, tglx@...utronix.de, mingo@...hat.com, h.peter.anvin@...el.com, peterz@...radead.org, will.deacon@....com, dwindsor@...il.com, ishkamiel@...il.com Subject: Re: [RFC PATCH 01/19] Since we need to change the implementation, stop exposing internals. Provide kref_read() to read the current reference count; typically used for debug messages. On Thu, Dec 29, 2016 at 08:55:53AM +0200, Elena Reshetova wrote: > Kills two anti-patterns: > > atomic_read(&kref->refcount) > kref->refcount.counter > > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org> If you are going to send patches out, do it right, with a correct subject, your signed-off-by: added, and the rest. Otherwise it just makes some of us cringe when we have to read these...
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.