Date: Thu, 22 Dec 2016 05:40:09 +0100 From: "Jason A. Donenfeld" <Jason@...c4.com> To: George Spelvin <linux@...encehorizons.net> Cc: Andi Kleen <ak@...ux.intel.com>, David Miller <davem@...emloft.net>, David Laight <David.Laight@...lab.com>, "Daniel J . Bernstein" <djb@...yp.to>, Eric Biggers <ebiggers3@...il.com>, Eric Dumazet <eric.dumazet@...il.com>, Hannes Frederic Sowa <hannes@...essinduktion.org>, Jean-Philippe Aumasson <jeanphilippe.aumasson@...il.com>, kernel-hardening@...ts.openwall.com, Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Andy Lutomirski <luto@...capital.net>, Netdev <netdev@...r.kernel.org>, Tom Herbert <tom@...bertland.com>, Linus Torvalds <torvalds@...ux-foundation.org>, "Theodore Ts'o" <tytso@....edu>, Vegard Nossum <vegard.nossum@...il.com> Subject: Re: Re: HalfSipHash Acceptable Usage Hi George, On Thu, Dec 22, 2016 at 4:55 AM, George Spelvin <linux@...encehorizons.net> wrote: > Do we have to go through this? No, the benchmark was *not* bogus. > Then I replaced the kernel #includes with the necessary typedefs > and #defines to make it compile in user-space. > * I didn't iterate 100K times, I timed the functions *once*. > * I saved the times in a buffer and printed them all at the end > so printf() wouldn't pollute the caches. > * Before every even-numbered iteration, I flushed the I-cache > of everything from _init to _fini (i.e. all the non-library code). > This cold-cache case is what is going to happen in the kernel. Wow! Great. Thanks for the pointers on the right way to do this. Very helpful, and enlightening results indeed. Think you could send me the whole .c of what you finally came up with? I'd like to run this on some other architectures; I've got a few odd boxes laying around here. > The P4 results were: > SipHash actually wins slightly in the cold-cache case, because > it iterates more. In the hot-cache case, it loses > Core 2 duo: > Pretty much a tie, honestly. > Ivy Bridge: > Modern processors *hate* cold caches. But notice how md5 is *faster* > than SipHash on hot-cache IPv6. > Ivy Bridge, -m64: > Of course, when you compile -m64, SipHash is unbeatable. Okay, so I think these results are consistent with some of the assessments from before -- that SipHash is really just fine as a replacement for MD5. Not great on older 32-bit x86, but not too horrible, and the performance improvements on every other architecture and the security improvements everywhere are a net good. > Here's the modified benchmark() code. The entire package is > a bit voluminous for the mailing list, but anyone is welcome to it. Please do send! I'm sure I'll learn from reading it. Thanks again for doing the hardwork of putting something proper together. Thanks, Jason
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.