Date: Thu, 15 Dec 2016 19:51:13 +0100 From: "Jason A. Donenfeld" <Jason@...c4.com> To: David Laight <David.Laight@...lab.com> Cc: Netdev <netdev@...r.kernel.org>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, LKML <linux-kernel@...r.kernel.org>, "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>, Jean-Philippe Aumasson <jeanphilippe.aumasson@...il.com>, Ted Tso <tytso@....edu> Subject: Re: [PATCH v3 3/3] random: use siphash24 instead of md5 for get_random_int/long Hi David, On Thu, Dec 15, 2016 at 11:14 AM, David Laight <David.Laight@...lab.com> wrote: > From: Behalf Of Jason A. Donenfeld >> Sent: 14 December 2016 18:46 > ... >> + ret = *chaining = siphash24((u8 *)&combined, offsetof(typeof(combined), end), > > If you make the first argument 'const void *' you won't need the cast > on every call. > > I'd also suggest making the key u64. I'll do both. Thanks for the suggestion. Jason
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.