Date: Wed, 14 Dec 2016 18:49:26 +0100 From: "Jason A. Donenfeld" <Jason@...c4.com> To: David Laight <David.Laight@...lab.com> Cc: Hannes Frederic Sowa <hannes@...essinduktion.org>, Netdev <netdev@...r.kernel.org>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, Andi Kleen <ak@...ux.intel.com>, LKML <linux-kernel@...r.kernel.org>, Linux Crypto Mailing List <linux-crypto@...r.kernel.org> Subject: Re: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform On Wed, Dec 14, 2016 at 3:47 PM, David Laight <David.Laight@...lab.com> wrote: > Just remove the __packed and ensure that the structure is 'nice'. > This includes ensuring there is no 'tail padding'. > In some cases you'll need to put the port number into a 32bit field. I'd rather not. There's no point in wasting extra cycles on hashing useless data, just for some particular syntactic improvement. __packed __aligned(8) will do what we want perfectly, I think. > I'd also require that the key be aligned. Yep, I'll certainly do this for the siphash24_aligned version in the v3.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.