Date: Thu, 17 Nov 2016 11:16:42 +0100 From: Peter Zijlstra <peterz@...radead.org> To: Julia Lawall <julia.lawall@...6.fr> Cc: "Reshetova, Elena" <elena.reshetova@...el.com>, Rik van Riel <riel@...hat.com>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, Will Deacon <will.deacon@....com>, Greg KH <gregkh@...uxfoundation.org>, David Windsor <dave@...gbits.org>, Arnd Bergmann <arnd@...db.de>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "Anvin, H Peter" <h.peter.anvin@...el.com> Subject: Re: Re: [RFC v4 PATCH 00/13] HARDENED_ATOMIC On Thu, Nov 17, 2016 at 10:36:47AM +0100, Julia Lawall wrote: > > > On Thu, 17 Nov 2016, Peter Zijlstra wrote: > > > On Wed, Nov 16, 2016 at 05:34:48PM +0000, Reshetova, Elena wrote: > > > > > I have a coccinelle rule now that found about 15 usages of it. > > > > Right, so can coccinelle detect the call_rcu/free call that is > > conditional on the dec_and_test when its hidden inside a few function > > calls? > > > > Also, we should really have a "make spatch" target so that we can run > > the thing concurrently with -j80 or somesuch, because as is coccinelle > > is unbearably slow. > > In the kernel, there is already the make coccicheck infrastructure. It > suffices to add the semantic patch to a subdirectory of > scripts/coccinelle. Shiny.. however: $ make coccicheck COCCI=kref.cocci MODE=patch V=1 /bin/bash ./scripts/coccicheck Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. Processing kref.cocci with option(s) "" Message example to submit a patch: The semantic patch that makes this change is available in kref.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Running (8 in parallel): /usr/bin/spatch -D patch --very-quiet --cocci-file kref.cocci --dir . -I ./arch/x86/include -I ./arch/x86/include/generated/uapi -I ./arch/x86/include/generated -I ./include -I ./arch/x86/include/uapi -I ./include/uapi -I ./include/generated/uapi --include ./include/linux/kconfig.h --jobs 8 --chunksize 1 coccicheck failed No joy :-(
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.