[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161111123516.GF11945@leverpostej>
Date: Fri, 11 Nov 2016 12:35:16 +0000
From: Mark Rutland <mark.rutland@....com>
To: kernel-hardening@...ts.openwall.com
Cc: Will Deacon <will.deacon@....com>,
"keescook@...omium.org" <keescook@...omium.org>,
"arnd@...db.de" <arnd@...db.de>,
"tglx@...utronix.de" <tglx@...utronix.de>,
"mingo@...hat.com" <mingo@...hat.com>,
"Anvin, H Peter" <h.peter.anvin@...el.com>,
"peterz@...radead.org" <peterz@...radead.org>,
David Windsor <dwindsor@...il.com>,
Hans Liljestrand <ishkamiel@...il.com>
Subject: Re: RE: [RFC v4 PATCH 09/13] drivers: identify
wrapping atomic usage (part 1/2)
On Fri, Nov 11, 2016 at 08:57:18AM +0000, Reshetova, Elena wrote:
> On Thu, Nov 10, 2016 at 10:24:44PM +0200, Elena Reshetova wrote:
> > From: David Windsor <dwindsor@...il.com>
> >
> > In some cases atomic is not used for reference counting and therefore
> > should be allowed to overflow.
> > Identify such cases and make a switch to non-hardened atomic version.
> >
> > This might need more fine-grained split between different drivers.
> > 88 files changed, 491 insertions(+), 459 deletions(-)
> >How did you decide that all of these need to wrap? Code inspection?
>
> Yes. The initial set was taken from Grsecurity/PaX code and while
> moving the code we manually checked each change.
That being the case, it would be good if you could provide some
{driver,subsystem}-specific rationale in the commit messages when this
is split. i.e. describe what the atomics are acutally used for, and why
wrapping is (or is not) safe.
> Certainly there are things that are missed here and that's why it
> needs more review.
> Also, we were planning to break this patch even further by related
> drivers, so we can take it to relevant people for review also.
I think that's necessary for any reasonable review to happen. Hopefully
there are subsystem-specific idioms for related drivers that make this
possible.
Thanks,
Mark.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
