kernel-hardening - Re: [RFC v3 PATCH 01/13] Add architecture independent hardened atomic base

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1478001210.2236.28.camel@cvidal.org>
Date: Tue, 01 Nov 2016 12:53:30 +0100
From: Colin Vidal <colin@...dal.org>
To: kernel-hardening@...ts.openwall.com
Cc: keescook@...omium.org, arnd@...db.de, tglx@...utronix.de,
 mingo@...hat.com,  h.peter.anvin@...el.com, Elena Reshetova
 <elena.reshetova@...el.com>, Hans Liljestrand <ishkamiel@...il.com>, David
 Windsor <dwindsor@...il.com>
Subject: Re: [RFC v3 PATCH 01/13] Add architecture
 independent hardened atomic base

Hi (again :-)) Elena, Hans,

> diff --git a/include/linux/atomic.h b/include/linux/atomic.h
<snip>
> +#ifndef atomic_cmpxchg_wrap
> +#define  atomic_cmpxchg_wrap(...)				\
> +	__atomic_op_fence(atomic_cmpxchg_wrap, __VA_ARGS__)
> +#endif
>  #endif /* atomic_cmpxchg_relaxed */
> 

I have a problem here. With ARMv7 (without any of my patches), I have a
implicit declaration of atomic_cmpxchg_wrap. Perhaps something like

    #ifndef atomic_cmpxchg_wrap_relaxed
    #define atomic_cmpxchg_wrap_relaxed atomic_cmpxchg_wrap

is missing? I didn't follow the recent changes of that part, so I am
not quite sure...

Thanks!

Colin

In file included from ./include/linux/spinlock.h:406:0,
                 from ./include/linux/seqlock.h:35,
                 from ./include/linux/time.h:5,
                 from ./include/linux/stat.h:18,
                 from ./include/linux/module.h:10,
                 from net/ipv4/route.c:67:
net/ipv4/route.c: In function ‘ip_idents_reserve’:
./include/linux/atomic.h:459:20: error: implicit declaration of function ‘atomic_cmpxchg_wrap_relaxed’ [-Werror=implicit-function-declaration]
  __atomic_op_fence(atomic_cmpxchg_wrap, __VA_ARGS__)
                    ^
./include/linux/atomic.h:62:9: note: in definition of macro ‘__atomic_op_fence’
  typeof(op##_relaxed(args)) __ret;    \
         ^~
net/ipv4/route.c:488:11: note: in expansion of macro ‘atomic_cmpxchg_wrap’
  } while (atomic_cmpxchg_wrap(p_id, old, new) != old);

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.