Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 5 Aug 2016 12:37:13 +0200
From: Pavel Machek <>
To: "Rafael J. Wysocki" <>
Cc: the arch/x86 maintainers <>,
	Linux PM list <>,
	"Rafael J. Wysocki" <>,
	Thomas Garnier <>,
	Thomas Gleixner <>,
	Ingo Molnar <>, "H . Peter Anvin" <>,
	Kees Cook <>, Yinghai Lu <>,
	LKML <>,
Subject: Re: [PATCH] x86/power/64: Do not refer to __PAGE_OFFSET from
 assembly code

On Wed 2016-08-03 01:19:26, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <>
> When CONFIG_RANDOMIZE_MEMORY is set on x86-64, __PAGE_OFFSET becomes
> a variable and using it as a symbol in the image memory restoration
> assembly code under core_restore_code is not correct any more.

On a related note... we should really have page_offset variable in
such case, and use that -- having __FOO_BAR not being a constant is

> To avoid that problem, modify set_up_temporary_mappings() to compute
> the physical address of the temporary page tables and store it in
> temp_level4_pgt, so that the value of that variable is ready to be
> written into CR3.  Then, the assembly code doesn't have to worry
> about converting that value into a physical address and things work
> regardless of whether or not CONFIG_RANDOMIZE_MEMORY is set.
> Reported-and-tested-by: Thomas Garnier <>
> Signed-off-by: Rafael J. Wysocki <>

Acked-by: Pavel Machek <>

Is similar patch needed for i386?

Best regards,

(cesky, pictures)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.