[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 07 Jul 2016 12:35:17 -0400
From: Rik van Riel <riel@...hat.com>
To: Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
Cc: Casey Schaufler <casey@...aufler-ca.com>, PaX Team
<pageexec@...email.hu>,
Brad Spengler <spender@...ecurity.net>,
Russell
King <linux@...linux.org.uk>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
Ard Biesheuvel
<ard.biesheuvel@...aro.org>,
Benjamin Herrenschmidt
<benh@...nel.crashing.org>,
Michael Ellerman <mpe@...erman.id.au>,
Tony
Luck <tony.luck@...el.com>, Fenghua Yu <fenghua.yu@...el.com>,
"David S.
Miller" <davem@...emloft.net>, x86@...nel.org,
Christoph Lameter
<cl@...ux.com>, Pekka Enberg <penberg@...nel.org>,
David Rientjes
<rientjes@...gle.com>,
Joonsoo Kim <iamjoonsoo.kim@....com>,
Andrew Morton
<akpm@...ux-foundation.org>,
Andy Lutomirski <luto@...nel.org>, Borislav
Petkov <bp@...e.de>,
Mathias Krause <minipli@...glemail.com>, Jan Kara
<jack@...e.cz>,
Vitaly Wool <vitalywool@...il.com>,
Andrea Arcangeli
<aarcange@...hat.com>,
Dmitry Vyukov <dvyukov@...gle.com>,
Laura Abbott
<labbott@...oraproject.org>,
linux-arm-kernel@...ts.infradead.org, linux-ia64@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, sparclinux@...r.kernel.org,
linux-arch@...r.kernel.org, linux-mm@...ck.org,
kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH 1/9] mm: Hardened usercopy
On Wed, 2016-07-06 at 15:25 -0700, Kees Cook wrote:
>
> + /* Allow kernel rodata region (if not marked as Reserved).
> */
> + if (ptr >= (const void *)__start_rodata &&
> + end <= (const void *)__end_rodata)
> + return NULL;
>
One comment here.
__check_object_size gets "to_user" as an argument.
It may make sense to pass that to check_heap_object, and
only allow copy_to_user from rodata, never copy_from_user,
since that section should be read only.
> +void __check_object_size(const void *ptr, unsigned long n, bool
> to_user)
> +{
>
--
All Rights Reversed.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
