Date: Tue, 10 May 2016 07:58:54 +0200 From: Ingo Molnar <mingo@...nel.org> To: Yinghai Lu <yinghai@...nel.org> Cc: Kees Cook <keescook@...omium.org>, Borislav Petkov <bp@...e.de>, Baoquan He <bhe@...hat.com>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>, Vivek Goyal <vgoyal@...hat.com>, Andy Lutomirski <luto@...nel.org>, Lasse Collin <lasse.collin@...aani.org>, Andrew Morton <akpm@...ux-foundation.org>, Dave Young <dyoung@...hat.com>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, LKML <linux-kernel@...r.kernel.org>, Linus Torvalds <torvalds@...ux-foundation.org> Subject: Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time * Yinghai Lu <yinghai@...nel.org> wrote: > On Mon, May 9, 2016 at 3:23 PM, Kees Cook <keescook@...omium.org> wrote: > >> The exact reason to have assigning in functions. > >> > >> pgt_data address could be changed during kernel relocation. > >> so can not assigned during compiling time. > > > > Ah-ha, that explains why I had to keep it on the stack. Thanks for the > > clarification! > > My fault, I should put that comment in the code at first place. Ok, could you guys please update the code and the changelog as well, and also rename that horribly named prepare_level4() function? Also, since this code is multi-author, it would be nice to add explicit copyright notices to the new arch/x86/boot/compressed/pagetable.c file, it was originally written by you, then modified by Kees. Something like: /* * Copyright (C) 2015-2016 Yinghai Lu * Copyright (C) 2016 Kees Cook */ Thanks, Ingo
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.