Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 26 Jan 2016 14:26:24 +0800
From: Jianyu Zhan <>
To: Laura Abbott <>
Cc: Andrew Morton <>, 
	"Kirill A. Shutemov" <>, Vlastimil Babka <>, 
	Michal Hocko <>, "" <>, 
	LKML <>,, 
	Kees Cook <>
Subject: Re: [RFC][PATCH 1/3] mm/debug-pagealloc.c: Split out page poisoning
 from debug page_alloc

On Tue, Jan 26, 2016 at 12:55 AM, Laura Abbott
<> wrote:
> +static bool __page_poisoning_enabled __read_mostly;
> +static bool want_page_poisoning __read_mostly =
> +

I would say this patch is nice with regard to decoupling

But  since when we enable CONFIG_DEBUG_PAGEALLOC,
CONFIG_PAGE_POISONING will be selected.

So it would be better to make page_poison.c totally
CONFIG_DEBUG_PAGEALLOC agnostic,  in case we latter have
more PAGE_POISONING users(currently only DEBUG_PAGEALLOC ). How about like this:

+static bool want_page_poisoning __read_mostly =

Or just let it default to 'true',  since we only compile this
page_poison.c when we enable CONFIG_PAGE_POISONING.

Jianyu Zhan

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.