Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 11 Oct 2013 15:37:32 -0700
From: ebiederm@...ssion.com (Eric W. Biederman)
To: Ryan Mallon <rmallon@...il.com>
Cc: George Spelvin <linux@...izon.com>,  joe@...ches.com,  akpm@...ux-foundation.org,  dan.j.rosenberg@...il.com,  eldad@...refinery.com,  jgunthorpe@...idianresearch.com,  jkosina@...e.cz,  keescook@...omium.org,  kernel-hardening@...ts.openwall.com,  linux-kernel@...r.kernel.org,  viro@...iv.linux.org.uk,  rusty@...tcorp.com.au
Subject: Re: [PATCH v3a] vsprintf: Check real user/group id for %pK

Ryan Mallon <rmallon@...il.com> writes:

> The only remaining problem is kernel/module.c:module_sect_show() which
> is used to write the sysfs files in /sys/module/<modname>/sections/.
> Those files are actually are really good target for leaking %pK values
> via setuid binaries. The problem is that the module_sect_show() function
> isn't passed information about who opened the sysfs file. I don't think
> this information is available in general for sysfs files either. Also,
> I can't actually see how module_sect_show() gets called?
>
> I'm a bit stuck on how to solve this. Any ideas?

I haven't yet had a chance to review the patches but there are patches
to make sysfs files seq files in Greg's driver core tree.

Eric

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.