Date: Wed, 09 Oct 2013 16:21:51 -0700 From: Joe Perches <joe@...ches.com> To: Ryan Mallon <rmallon@...il.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, eldad@...refinery.com, Jiri Kosina <jkosina@...e.cz>, jgunthorpe@...idianresearch.com, Dan Rosenberg <dan.j.rosenberg@...il.com>, Kees Cook <keescook@...omium.org>, Alexander Viro <viro@...iv.linux.org.uk>, "Eric W. Biederman" <ebiederm@...ssion.com>, George Spelvin <linux@...izon.com>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v3a] vsprintf: Check real user/group id for %pK On Thu, 2013-10-10 at 10:18 +1100, Ryan Mallon wrote: > On 10/10/13 10:09, Joe Perches wrote: > > Do the in_irq tests only when kptr_restrict is 1. > > Document the %pK mechanism in vsnprintf > > Add missing documentation for %pV and %pNF too > > I really did mean post a follow-up/separate patch, not a different > version of mine. I think that's not the right thing to do. There's no good reason to have multiple commits for the same content. And almost all of that is actually stuff I wrote. Your content there is the cred checks. > > + cred = current_cred(); > > + if (!has_capability_noaudit(current, CAP_SYSLOG) || > > + !uid_eq(cred->euid, cred->uid) || > > + !gid_eq(cred->egid, cred->gid))
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.