Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGXu5jJMRRXFKi9XH9BBupxYYjq0SoxUxrmyYiB2H8h0QbN=UA@mail.gmail.com>
Date: Tue, 31 Jan 2012 11:22:42 -0800
From: Kees Cook <keescook@...omium.org>
To: Vasiliy Kulikov <segoon@...nwall.com>
Cc: Alexey Dobriyan <adobriyan@...il.com>, linux-kernel@...r.kernel.org, 
	Andrew Morton <akpm@...ux-foundation.org>, Linus Torvalds <torvalds@...ux-foundation.org>, 
	Randy Dunlap <rdunlap@...otime.net>, Borislav Petkov <bp@...en8.de>, Dan Ballard <dan@...dstab.net>, 
	Jiri Kosina <jkosina@...e.cz>, Al Viro <viro@...iv.linux.org.uk>, 
	Stephen Wilson <wilsons@...rt.ca>, David Rientjes <rientjes@...gle.com>, Ingo Molnar <mingo@...e.hu>, 
	Peter Zijlstra <a.p.zijlstra@...llo.nl>, Eric Paris <eparis@...hat.com>, 
	"Serge E. Hallyn" <serge.hallyn@...onical.com>, linux-doc@...r.kernel.org, 
	kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH v3] sysctl: control functionality of /proc/pid/mem

On Tue, Jan 24, 2012 at 3:51 AM, Vasiliy Kulikov <segoon@...nwall.com> wrote:
> On Tue, Jan 24, 2012 at 13:12 +0200, Alexey Dobriyan wrote:
>> On 1/24/12, Vasiliy Kulikov <segoon@...nwall.com> wrote:
>> >> +          .procname       = "proc_pid_mem",
>> >> +          .data           = &sysctl_proc_pid_mem,
>> >> +          .maxlen         = sizeof(int),
>> >> +          .mode           = 0644,
>> >> +          .proc_handler   = proc_dointvec_minmax,
>> >> +          .extra1         = &zero,
>> >> +          .extra2         = &two,
>> >> +  },
>>
>> >E.g. moving all such stuff to some sysctl group, not bloating
>> > kernel.*.
>>
>> Ehh.
>> How bloat is measured in this case?
>
> Do we want to add such sort of sysctls "from time to time" when we
> consider one or another feature as deprecated?  If yes, I'd group them
> somehow, e.g. by introducing subdirectory inside of kernel.
>
> Btw, kernel sysctl dir contains all sort of stuff which goes to "kernel"
> as if it is "etc".  It already contains ftrace, perf, printk, scheduler,
> ipc.  IMHO plain kernel hierarchy is not profitable in the long term.

Yeah, after reconsidering this, this sysctl is not the right approach.

-Kees

-- 
Kees Cook
ChromeOS Security

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.