Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 14 Dec 2011 23:06:56 -0800
From: Kees Cook <>
To: Ingo Molnar <>
Cc:, Randy Dunlap <>, 
	Alexander Viro <>, Rik van Riel <>, 
	Federica Teodori <>, 
	Lucian Adrian Grijincu <>, Andrew Morton <>, 
	Peter Zijlstra <>, Eric Paris <>, 
	Dan Rosenberg <>,,,
Subject: Re: [PATCH v2011.2] fs: symlink restrictions on sticky directories

On Wed, Dec 14, 2011 at 10:48 PM, Ingo Molnar <> wrote:

> * Kees Cook <> wrote:
>> +             ab = audit_log_start(current->audit_context,
>> +                                  GFP_ATOMIC, AUDIT_AVC);
> Hm, is GFP_ATOMIC really necessary here? Why not GFP_KERNEL?
> This is in VFS process context, not in some atomic context that
> has to be careful about allocations, right?

Hm, that's true. I had started from the lsm_audit interface, but had
to expand it, and in the process copied its use of audit_log_start().
But yeah, I don't see a reason it can't be GFP_KERNEL. I'll adjust it.



Kees Cook
ChromeOS Security

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.