Date: Mon, 19 Sep 2011 20:35:10 -0700 From: ebiederm@...ssion.com (Eric W. Biederman) To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Vasiliy Kulikov <segoon@...nwall.com>, Balbir Singh <bsingharora@...il.com>, Shailabh Nagar <nagar@...ibm.com>, linux-kernel@...r.kernel.org, security@...nel.org, Eric Paris <eparis@...hat.com>, Stephen Wilson <wilsons@...rt.ca>, KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>, David Rientjes <rientjes@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>, Balbir Singh <balbir@...ux.vnet.ibm.com>, kernel-hardening@...ts.openwall.com Subject: Re: [Security] [PATCH 2/2] taskstats: restrict access to user Linus Torvalds <torvalds@...ux-foundation.org> writes: > On Mon, Sep 19, 2011 at 10:39 AM, Vasiliy Kulikov <segoon@...nwall.com> wrote: >> >> Shouldn't it simply protect taskstats_user_cmd()? You may still poll >> the counters with TASKSTATS_CMD_ATTR_PID/TASKSTATS_CMD_ATTR_TGID. > > Yeah, I wondered where I'd really want to hook it in, that was the > other option. > > However, one thing that I'm currently independently asking some > networking people is whether that patch guarantees anything at all: is > the netlink command even guaranteed to be run in the same context as > the person sending it? I don't know where that conversation is happening but since I have been involved rather heavily in netlink syncrhonously processing messages I will answer. > After all, it comes in as a packet of data. How synchronous is the > genetlink thing guaranteed to be in the first place? Yes. The netlink skb is guaranteed to be processed synchronously and in the senders process. So accessing current is guaranteed to be valid. I just confirmed my memory by reading the cod in 3.1-rc1 > IOW, are *any* of those "check current capabilities/euid" approaches > really guaranteed to be valid? Are they valid today, will they > necessarily be valid in a year? They are valid until such time as someone as someone rearchitects netlink message processing. Several years ago it was decided that processing netlink messages syncrhonously so we could access current made for much simpler easier to understand kernel code, and most if not all of the netlink permissions checks now depend upon the fact that we process netlink messages synchronously. Eric
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.