Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 3 Jul 2011 13:23:11 +0100
From: Alan Cox <>
To: Vasiliy Kulikov <>
Cc: Linus Torvalds <>,
        Ingo Molnar
        Andrew Morton <>,
        James Morris
 <>, Namhyung Kim <>,
        Greg Kroah-Hartman
Subject: Re: [PATCH v2] kernel: escape non-ASCII and control characters in

> Also, the problem with CSI code is still here.  It cannot be filtered
> because it is a valid byte inside of UTF-8 character.  For a console
> with IUTF bit set all dangerous characters are filtered, but for the
> rest they are not.  As at the stage of vscnprintf the presence of IUTF
> bit is not clear, users of non-IUTF console should still use "| less" or
> similar.  Obviously, \n is filtered for all consoles.

This is why the filter pattern has to come from the console. Your patch
also for example doesn't fix anything on a 7bit serial console.. only the
hardware driver really knows what the filter rules are.

Looks a very good starting point though, and the embedded \n's mostly
want fixing up anyway.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.