Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 28 Jun 2011 12:30:14 -0700
From: Linus Torvalds <>
To: Vasiliy Kulikov <>
Cc: Alan Cox <>, Ingo Molnar <>,
        Andrew Morton <>,
        James Morris <>, Namhyung Kim <>,
        Greg Kroah-Hartman <>,,
Subject: Re: [PATCH v2] kernel: escape non-ASCII and control characters in printk()

On Mon, Jun 27, 2011 at 11:38 AM, Vasiliy Kulikov <> wrote:
> Sure, I don't propose it anymore (v2 goes without it).

What point would you like to filter things at?

I really think that user space should do its own filtering - nobody
does a plain 'cat' on dmesg. Or if they do, they really have
themselves to blame.

And afaik, we don't do any escape sequence handling at the console
level either, so you cannot mess up the console with control

And the most dangerous character seems to be one that you don't
filter: the one we really do react to is '\n', and you could possibly
make confusing log messages by embedding a newline in your string and
then trying to make the rest look like something bad (say, an oops).

So I'm not entirely convinced about this filtering at all.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.