Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 22 Jun 2011 10:14:01 -0700
From: Joe Perches <joe@...ches.com>
To: Vasiliy Kulikov <segoon@...nwall.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, James Morris
 <jmorris@...ei.org>,  Ingo Molnar <mingo@...e.hu>, Namhyung Kim
 <namhyung@...il.com>, Greg Kroah-Hartman <gregkh@...e.de>, 
 kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org, 
 security@...nel.org
Subject: Re: [PATCH] kernel: escape non-ASCII and control characters in
 printk()

On Wed, 2011-06-22 at 20:53 +0400, Vasiliy Kulikov wrote:
> On Wed, Jun 22, 2011 at 09:38 -0700, Joe Perches wrote:
> > > +	if ((c >= ' ' && c < 127) || c == '\n')
> > 	if (isprint(c))
> #define isprint(c)	((__ismask(c)&(_P|_U|_L|_D|_SP)) != 0)
> It slightly differs from what I've written.  It (1) lacks '\n',

You still need tab, so:

if (isprint(c) || isspace(c))

> (2) passes non-ASCII symbols.
> How would non-ASCII symbols look like if
> terminal doesn't support it?  (I don't know, merely asking).

I believe most would work fine.

Are there any lp01's or la36's still connected
to a serial console?

I don't know what would happen to a 7 bit
ascii only device.


Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.