Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Mon, 2 Aug 2010 17:37:15 -0400
From: "Robert Harris" <>
To: <>
Subject: Wiki page on patches is confusing, outdated


I find the Wiki page on patches (
confusing.   Not every patch is listed, some new patches are at the top of
the table,  and some are at the bottom

I'm not always sure if an individual patch is still relevant, or if it is
included in a jumbo patch

I'd love to see a readme that tells us the list of patches a jumbo patch
includes, and high level list of the bugs/fixes.  (Otherwise we have to
compare the difference patch files.) 


So, here is a real world example of the patches that seem to apply to 1.7.6
(except mpi and OpenMP):

John-1.7.6 applying patches in the following order:


john-1.7.6-jumbo-5-jmk-mschapv2.diff   (so, jumbo 6 does not contain,

john-1.7.6-jumbo-6-config.diff          (applies fine, makes sense since it
came out after jumbo 6.)             

john-1.7.6-fast-des-key-setup-3.diff   (worked, but minor issue with this
trying to modify the John_version number.  So the jumbo patches don't
include this for some reason)  

john-1.7.6-jumbo-3-krb5-2.diff  (did not patch, perhaps already in jumbo-6
or lower?)  (Yes, comparison of the Jumbo 6.diff to this patch seems to show
it is in there)        

john-1.7.6-single-have_words-fix-1.diff  (did not patch, perhaps already in
jumbo-6 or lower?)  (Yes, comparison of the Jumbo 6.diff to this patch seems
to show it is in there)  

What determines if a patch will or will not be included in the next jumbo

Let's say a  patch "a" is for version "b" of JtR with jumbo patch "c", let's
say a new version of JtR or a new jumbo patch comes out.    I'd like to see
the table get updated to say either patch A is integrated into the new
version and/or jumbo patch, or say something else like still relevant, patch
still can be applied to latest version X, or perhaps version X breaks this
patch, and it needs to be reworked (by the author)

Suggested improvements to the patches wiki page:

Adding a date column.

Changing the order of the patches, so it is in chronological order starting
with the oldest on top

Adding a status column (saying: added to current jumbo patch, apply this to
version x.x, patch y, or separate patch- currently relevant, or something

I'm willing to modify this page with these suggest, if the group tends to
agree, but I might need some help.

Anyone else have other ideas to make this page easier to understand/better?


-Robert Harris

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.