Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 23 Sep 2008 03:56:40 +0400
From: Solar Designer <>
Subject: Re: jumbo patch for

On Mon, Sep 22, 2008 at 12:27:37PM -0600, RB wrote:
> Can anyone discuss the changes to src/bench.c introduced in all-4 and
> continued in all-5?  They seem cosmetic and are interfering with
> cleanly applying both's mpi8 patch and the jumbo
> patches.

Thank you for bringing this up.

Yes, I introduced some changes of my own to bench.c.  No, they are not
entirely cosmetic - they sort of add functionality.  Previously, one
would have to actually watch the output of "john --test" or to scroll up
to make sure that no tests "FAILED".  With around 40 "formats", and with
running tests on multiple systems, possibly simultaneously - such as
before releasing a jumbo patch update - this became an issue.  With the
changes to bench.c, if any tests fail, JtR will now print a line at the
very end of its output saying that this-many tests have failed.  Thus,
only a quick glance at the terminal is sufficient.

It is unfortunate that the changes are interfering with another popular
patch, but I don't think I am going to do anything about that.  Perhaps
there will need to be a revision of's patch that will
apply cleanly on top of the jumbo patch.


To unsubscribe, e-mail and reply
to the automated confirmation request that will be sent to you.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.