[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Sat, 27 Feb 2016 22:44:36 -0600
From: jfoug <jfoug@...nwall.net>
To: john-dev@...ts.openwall.com
Subject: Changes needed for cygwin (-fork tty problems)
This has been a problem for me, since we have gotten cygwin working with
-fork. When complete (with abort with 'q' or the session completes),
the cygwin shell is screwed up (tty is in non-echo mode). I have lived
with this, but recently there are other user posts, where I see them
doing 'stty sane' calls after a -fork run (cygwin).
So I made a change to john.c
https://github.com/magnumripper/JohnTheRipper/commit/81e0cce6303cbea87420ccd70151f0779857b564
, so that when john exited, it did a system 'stty sane' call to clean
things up.. This seemed to work fine. However, magnum question why
this was done, and we had some discussion. Well to put things simply,
we found the 'real' bug on why cygwin was left in a tty non-echo mode.
It was fixed here:
https://github.com/magnumripper/JohnTheRipper/commit/5aebb0bc4f94e778be5f95599cd47313604a64a9
reverting the other 'hack',, and fixing the real problem. This fix
should be pushed down to john core, since this was code code in tty.
It may be that at some time, the getpid() or some other call in cygwin
was not working. Well, if this code IS done in cygwin, then when -fork=x
runs exit, the tty is left in a sane state. This code should really be
looked at, and likely the #ifndef __CYGWIN__ define should be removed.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
