Date: Sun, 19 Apr 2015 13:20:15 +0300 From: Aleksey Cherepanov <lyosha@...nwall.com> To: john-dev@...ts.openwall.com Subject: Re: Improving Johnny Hi Mathieu, On Sun, Apr 19, 2015 at 04:37:22AM +0300, Solar Designer wrote: > Mathieu, > > On Sat, Apr 18, 2015 at 09:03:39PM -0400, Mathieu Laprise wrote: > > > here is a line in Johnny: > > > > > > temp << QString("%1:%2::%3\n").arg(user).arg(hash).arg(hash); > > > > > > Do you see any problems with it? If there is a problem then > > > - provide an example of input to trigger the problem. > > > - How would you fix it? > > > - Does the fix work with your example? > > > - Push the fix into a separate branch in your public repo please. > > > > I really don't see how this question would tell you how experienced I am as > > a software engineer so I probably didn't understand it well. Ah ah :( So > > here is just my hypothesis after thinking about it for 2 minutes. > > Please spend more than 2 minutes thinking of this, and post a revised > answer. Thanks! Don't worry! You gave a correct answer. The beginning scares. But the answer is good and I really like it. Thanks! -- Regards, Aleksey Cherepanov
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.