Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 11 Mar 2015 19:24:45 +0100
From: Frank Dittrich <>
Subject: Re: john-jumbo bug

Hi Lei,

On 03/11/2015 07:12 PM, 张 磊 wrote:
> Hi,
> There’s seems to be a bug in file mssql12_fmt_plug.c (john-jumbo).
> The variable ‘max_keys’ gets defined in line 107, if the macro ‘MMX_COEF_SHA512’ is predefined.
> But the use of ‘max_key’ in line 186 doesn’t check if ‘MMX_COEF_SHA512’ is predefined. So variable ‘max_keys’ might be undefined here.

What is the latest bleeding-jumbo commit, and what local changes do you
have in your repository?

In my local repository, the latest commit is

This is line 109 of mssql12_fmt_plug.c:
static int max_keys;

This is line 171:
	max_keys = self->params.max_keys_per_crypt;

Both are inside
#ifdef MMX_COEF_SHA512

There is no other use of max_keys, and no use of max_key.
Please check and clarify.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.