Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 30 May 2013 23:18:59 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Unify internal form of mscash2 hashes?

On 30 May, 2013, at 21:20 , "jfoug" <jfoug@....net> wrote:
> Shouldn't the ROUNDS_PREFIX define be within the cryptsha512_valid.h file also?  Or is it only valid to have that string in only one of the underlying formats?

Speaking of that I probably screwed it in the memdbg tree because I moved the #include "cryptsha512_valid.h" to before memdbg.h but the definition of ROUNDS_PREFIX stayed so it's now after the header inclusion. I tested it in bleeding but not in memdbg...

> Also, the cuda version should use this same header file, and have it's in-source valid() function removed also.  The whole exercise is to get down to only ONE instance of that valid() that is shared by all of the same formats which may have implementations for various architectures in different files, so that these pre-filtration functions (which are NOT part of the core architecture specific code), is exactly the same for all of them.

Yep.

magnum

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.