Date: Tue, 07 May 2013 18:00:14 +0400 From: Alexander Cherepanov <cherepan@...me.ru> To: john-dev@...ts.openwall.com Subject: Non-ASCII characters in various files -- core and jumbo Hi! There are some non-ascii chars in various files and not everything is in the same encoding. 1. Core. There is only one non-ascii char in core tree -- in "R<E9>mi Guyomarch" in doc/CREDITS. If this is in iso-8859-1 then it translates to Rémi Guyomarch. Isn't it better to convert it to utf-8 or to pure ascii form? 2. Jumbo. - There are some places where non-ascii char can easily be eliminated -- patches attached. - There are multiple names in utf-8. This is probably Ok. - There are two strings of lower- and upper-case letters from iso-8859-1 in doc/RULES. They are -- surprise:-) -- in iso-8859-1. IMHO it's better to remove them or to convert the file to utf-8. - src/encoding_data.h contains many chars in utf-8. It's probably Ok to have one files where all such stuff lives. - src/rules.c contains several comments with non-ascii chars copied from src/encoding_data.h. Not sure, maybe remove them or non-ascii chars? What do you think? -- Alexander Cherepanov View attachment "0001-Replace-unicode-em-dash-in-putty-files.patch" of type "text/x-patch" (1393 bytes) View attachment "0002-Replace-non-ascii-char-by-hex-code-in-pass_gen.pl.patch" of type "text/x-patch" (1109 bytes) View attachment "0003-Replace-several-non-ascii-copyright-signs-by-c-strin.patch" of type "text/x-patch" (2391 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.