Date: Mon, 6 May 2013 00:58:43 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: Yet more crashes On 6 May, 2013, at 0:45 , Alexander Cherepanov <cherepan@...me.ru> wrote: > On 2013-05-06 01:35, magnum wrote: >> On 4 May, 2013, at 0:42 , Lukas Odzioba<lukas.odzioba@...il.com> wrote: >>> 2013/5/3 magnum<john.magnum@...hmail.com>: >>>> This was b0rken. >>>> >>>> $ ../run/john --test -form:sip >>>> Benchmarking: SIP MD5 [32/64]... FAILED (valid) >>>> >>>> + if (strspn(ciphertext, "*") != 14) >>>> + return 0; >>>> >>>> This strspn() will return the length of ciphertext, from start of it, that consist of characters within the string "*", ie. none. For eg. "**hel*lo**" it would return 2. >>> >>> Fsck this was stupid...I am sorry about that. >>> <sip_valid_fixed.diff> >> >> I missed that you submitted a new patch here! It's committed now. Also, I fixed OpenVMS format so its valid() should catch a lot more bad stuff. > > Commited only to bleeding? Sorry, now to unstable as well. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.