Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 23 Apr 2013 21:58:55 +0200
From: magnum <>
Subject: Re: minor raw-sha1-ng pull request

On 23 Apr, 2013, at 19:34 , Tavis Ormandy <> wrote:
> magnum <> wrote:
>> On 21 Apr, 2013, at 1:27 , Solar Designer
>> <> wrote:
>>> Tavis, magnum -
>>> On Fri, Apr 19, 2013 at 06:25:50PM -0700, Tavis Ormandy wrote:
>>>> Thanks for the explanation Magnum, I get similar results! I can
>>>> restructure cmp_all so it's also omp safe, I sent you a pull request
>>>> for that. It get's anoter 2000K c/s on my machine.
>>> Thanks!
>>> The attached patch replaces the heavy "#pragma omp atomic" with much
>>> lighter OpenMP reduction for the bitwise OR.  I've checked the OpenMP
>>> 2.5 spec (from 2005) - bitwise OR was already supported in the reduction
>>> clause, so I think we're good in terms of portability.
>> This is committed. Unstable branch still has the non-OMP version. Should
>> we merge these changes to it?
> Sounds like a good idea to me, do you want a pull request for that?
> Tavis.

No thanks, I can just cherry-pick the commits. I'm just not sure it's a good idea - unstable is supposed to be feature-frozen. Hopefully the time between 1.7.9-Jumbo-8 (unstable branch) and 1.8-Jumbo-1 (bleeding branch) will not be too long.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.