Date: Fri, 12 Apr 2013 22:18:25 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: jumbo pull request #255 (trouble with static builds) On 12 Apr, 2013, at 1:03 , John Spencer <maillist-johndev@...fooze.de> wrote: > hi list, > > https://github.com/magnumripper/JohnTheRipper/pull/255 > > basically the makefile currently links to -lssl -lcrypto unconditionally. > when static linking this leads to duplicate symbols from builtin sources > i.e. MD5_Init, MD4_Init. those are in libcrypto and in jtr source files md5.c and md4.c. > both files have checks for HAVE_OPENSSL in them. > so defining these at build time makes them omit their content, i.e. empty object files. > > thus i've added the CFLAG -DHAVE_OPENSSL unconditionally as well. > this fixes the problem. > > this is one of two possible fixes, the alternative is that a proper check for an installed openssl is done (or the user can choose) and if so add both -DHAVE_OPENSSL to CFLAGS and -lssl -lcrypto to LDFLAGS. Hi, I think the HAVE_OPENSSL stuff should be overhauled in general. I welcome any improvements but I'd rather have pull requests made against the bleeding-jumbo as the unstable one is pending a release of Jumbo-8. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.