Date: Fri, 12 Apr 2013 21:35:55 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Cc: Lukas Odzioba <lukas.odzioba@...il.com> Subject: Re: All *2john programs should use basename of filename when put as ?login? field On 18 Mar, 2013, at 1:47 , Lukas Odzioba <lukas.odzioba@...il.com> wrote: > 2013/3/18 magnum <john.magnum@...hmail.com>: >> Not sure I understand. Maybe you should just add a separate get_basename.cpp file then. Ideally we should port all C++ files to C. > I agree, and for now copy of get_basename() in only gpg2john.cpp is ok. > >> strnzcpy(retmem, base, retsize < 256 ? retsize : 256); >> >> The ternary is not needed. Just use >> >> strnzcpy(retmem, base, sizeof(retmem)); > > Thx I'll fix that, > Lukas You never posted the basename patch, did you? BTW we're also waiting for GPU version of pbkdf2-hmac-sha512 ;-) magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.